feat: add or expression #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yingcai-cy
commented
Jun 10, 2025
yingcai-cy
commented
- or expression
- change negate return type form Result to Expression
- add some tests
- or expression - change negate return type form Result to Expression - add some tests
wgtmac
requested changes
Jun 20, 2025
| virtual Result<std::shared_ptr<Expression>> Negate() const { | ||
| return InvalidExpression("Expression cannot be negated"); | ||
| virtual std::shared_ptr<Expression> Negate() const { | ||
| throw IcebergError("Expression cannot be negated"); |
Member
There was a problem hiding this comment.
Why changing the return type? We need to stick to Result instead of exception.
Contributor
Author
There was a problem hiding this comment.
It’s been a couple of days, let me recall. I believe the reason is that all expression implementations have a corresponding Negate form, so none of them would return incorrect results in this context.
Contributor
There was a problem hiding this comment.
Everything can be negated in theory, and this is also the case in practice.
Fokko
approved these changes
Jun 23, 2025
| virtual Result<std::shared_ptr<Expression>> Negate() const { | ||
| return InvalidExpression("Expression cannot be negated"); | ||
| virtual std::shared_ptr<Expression> Negate() const { | ||
| throw IcebergError("Expression cannot be negated"); |
Contributor
There was a problem hiding this comment.
Everything can be negated in theory, and this is also the case in practice.
Contributor
|
Thanks @yingcai-cy for working on this, and @wgtmac for the review 🚀 |
lishuxu
pushed a commit
to lishuxu/iceberg-cpp
that referenced
this pull request
Jul 5, 2025
- or expression - change negate return type form Result to Expression - add some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.